Reply with PUBACK when receiving a QoS1 PUBLISH #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client automatically replies with PUBACK when receiving a PUBLISH of QoS 1 while waiting for another message
njh
reviewed
Jun 15, 2018
| if(type == packet[1]){ | ||
| return packet; | ||
| } | ||
| mqtt_sn_send_puback(sock,(publish_packet_t *)packet,rc); |
There was a problem hiding this comment.
Puback is sent in
Line 260 in ff65892
I am trying to remember why mqtt_sn_print_publish_packet() is inside mqtt_sn_wait_for()
But I guess that is the same reason why you are missing some PUBACKs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client automatically replies with PUBACK when receiving a PUBLISH of QoS 1 while waiting for another message
#30 - Bug fix